That's a good point - the choice of crop will have a large bearing. I don't know if low margin crops like grains could provide an adequate ROI given electricity costs etc, let alone the outlay required to build structures over huge areas.

In my understanding vertical farming is usually a hydrocultural practice (doesn't use soil). That works well for a lot of horticulture, but not so much for broadacre crops.